♻️ Unify the testing functionality#1792
Draft
svlandeg wants to merge 4 commits into
Draft
Conversation
svlandeg
changed the title
CLIRunner classes
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - don't merge yet, I want to come back to this to see if there's anything more to clean up.
Description
Continuation of #1774, and addressing #1790: merging Typer's and Click's
CLIRunnerfunctionality intotyper.testingmodule.One potentially breaking change:
Removed the option to pass a stream to
CLIRunner.invoke(). We aren't using this in Typer and it isn't documented. Cf this commit.AI Disclaimer
No AI used.
Checklist
This is just a code refactor, no new tests.