Remove unneccessary access token from update workflow#597
Merged
dtandersen merged 1 commit intofactoriotools:masterfrom Dec 3, 2025
Merged
Remove unneccessary access token from update workflow#597dtandersen merged 1 commit intofactoriotools:masterfrom
dtandersen merged 1 commit intofactoriotools:masterfrom
Conversation
It is not necessary to use a PAT to check out a public repository. Because it is defined, the PAT eventually will expire and the action will stop working. By leaving it at default, the workflow generates a new Github token every time it runs which is enough to check out the repo.
Author
|
Should result in the update workflow being fixed, the docker build resuming, and resolve #595 |
|
Any chance of getting this merged soon @dtandersen? Would love to update my server to the latest stable without needing to switch to a fork |
Member
|
Last time I checked, it is not possible for those tokens to push and trigger github actions https://github.com/factoriotools/factorio-docker/blob/master/update.sh#L168-L169 |
Author
|
Works fine in my fork
…On Mon, Dec 1, 2025, at 12:16 PM, Sandro wrote:
*SuperSandro2000* left a comment (factoriotools/factorio-docker#597) <#597 (comment)>
Last time I checked, it is not possible for those tokens to push *and* trigger github actions https://github.com/factoriotools/factorio-docker/blob/master/update.sh#L168-L169
—
Reply to this email directly, view it on GitHub <#597 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASBTZGNBHP2WBLVP5DFK337SAYPAVCNFSM6AAAAACMCZPLROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOJYGE2DMMRSGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Member
|
I don't think this would affect the git push in update.sh, only the checkout. It looks fine to me, but I'm reluctant to push to master since I've been uninvolved for so long! Are there any objections to merging? |
Member
|
It is done. Hopefully nothing explodes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not necessary to use a personal access token (PAT) for this action. Because it is defined, the PAT eventually will expire and the action will stop working as it has now. By leaving it empty, Github populates a one-time token at the start of the workflow that will work for this repo for the purpose of the action.