Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Pin numpy version to prevent further upgrade problems#561

Open
ruanslv wants to merge 3 commits into
mainfrom
numpy
Open

Pin numpy version to prevent further upgrade problems#561
ruanslv wants to merge 3 commits into
mainfrom
numpy

Conversation

@ruanslv

@ruanslv ruanslv commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

Numpy 1.24.0 deprecated np.float, causing metaseq to throw errors: https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations

Given the number of bytes in the map I'm assuming we meant float32 here, even though np.float actually used 8 bytes instead of 4...

@suchenzang

Copy link
Copy Markdown
Contributor

whoops, we should probably pin a numpy version. separately - gpu test broken? ;_;

@ruanslv

ruanslv commented Dec 22, 2022

Copy link
Copy Markdown
Contributor Author

Test breakage is unrelated, it was already present before: https://app.circleci.com/pipelines/github/facebookresearch/metaseq/1223/workflows/06606d26-917b-422c-8717-0c316ec449a4/jobs/1714

As for pinning a version, isn't it better not to pin if we can so we can automatically get gains/advantages from future versions? Like this update, for example, it's good for our code-base as the type became clearer.

If we pin we are putting more work on ourselves later to update packages manually, which may be more painful to do if you have to do several packages in bulk?

@stephenroller

Copy link
Copy Markdown
Contributor

We have cython extensions that depend on numpy. I've found that accidental upgrades of numpy can break those extensions and cause very weird build errors on installation. So I would also be in favor of pinning numpy, at least to a major version like numpy~=1.22.0

@ruanslv ruanslv changed the title Fix numpy upgrade issue Pin numpy version to prevent further upgrade problems Dec 27, 2022
@ruanslv

ruanslv commented Dec 27, 2022

Copy link
Copy Markdown
Contributor Author

Actual crash fixed in #571. Pinned the current release and updated PR title

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants