misc: Add pipeline-level driver timing stats#17237
Closed
spershin wants to merge 1 commit intofacebookincubator:mainfrom
Closed
misc: Add pipeline-level driver timing stats#17237spershin wants to merge 1 commit intofacebookincubator:mainfrom
spershin wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
|
@spershin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101395498. |
Build Impact AnalysisSelective Build Targets (building these covers all 345 affected)Total affected: 345/567 targets Affected targets (345)Directly changed (134)
Transitively affected (211)
Fast path • Graph from main@7ed90a53dee9e640cba92a644dae85fe52b07fb9 |
spershin
changed the title
CI Failure Analysis❌ Expression Fuzzer with Presto SOT — FUZZER Failure View logsFuzzer: Presto Expression Fuzzer with Presto as Source of Truth Error: Velox and Presto reference DB results don't match The fuzzer instance crashed with SIGABRT after the assertion failure. Correlation with PR changes: Known issues:
Reproduce locally: ./velox_expression_fuzzer_test \
--seed 699216811 \
--enable_variadic_signatures \
--velox_fuzzer_enable_complex_types \
--lazy_vector_generation_ratio 0.2 \
--common_dictionary_wraps_generation_ratio=0.3 \
--velox_fuzzer_enable_column_reuse \
--velox_fuzzer_enable_expression_reuse \
--enable_dereference \
--duration_sec 300 \
--special_forms="cast,coalesce,if" \
--velox_fuzzer_max_level_of_nesting=1 \
--presto_url=http://127.0.0.1:8080(Requires a running Presto server on port 8080) Recommended action: |
meta-codesync
Bot
changed the title
spershin
force-pushed
the
export-D101395498
branch
from
b1dab50 to
131a608
Compare
spershin
added a commit
to spershin/velox-1
that referenced
this pull request
Apr 21, 2026
Summary: Operator stats have gaps and to suitable to determine where time went in a task. Adding driver timing stats per pipeline to assist in understanding a query bottlenecks. The current version does not handle the grouped execution well. Working on the extra to support grouped execution as well. Differential Revision: D101395498
spershin
added a commit
to spershin/velox-1
that referenced
this pull request
Apr 21, 2026
Summary: Operator stats have gaps and to suitable to determine where time went in a task. Adding driver timing stats per pipeline to assist in understanding a query bottlenecks. The current version does not handle the grouped execution well. Working on the extra to support grouped execution as well. Differential Revision: D101395498
spershin
force-pushed
the
export-D101395498
branch
from
131a608 to
8e033db
Compare
spershin
added a commit
to spershin/velox-1
that referenced
this pull request
Apr 21, 2026
Summary: Operator stats have gaps and to suitable to determine where time went in a task. Adding driver timing stats per pipeline to assist in understanding a query bottlenecks. The current version does not handle the grouped execution well. Working on the extra to support grouped execution as well. Differential Revision: D101395498
spershin
force-pushed
the
export-D101395498
branch
from
8e033db to
46a95cc
Compare
spershin
changed the title
spershin
added a commit
to spershin/velox-1
that referenced
this pull request
Apr 21, 2026
Summary: Pull Request resolved: facebookincubator#17237 Operator stats have gaps and to suitable to determine where time went in a task. Adding driver timing stats per pipeline to assist in understanding a query bottlenecks. The current version does not handle the grouped execution well. Working on the extra to support grouped execution as well. Differential Revision: D101395498
spershin
force-pushed
the
export-D101395498
branch
from
46a95cc to
3bec709
Compare
meta-codesync
Bot
changed the title
Contributor
bikramSingh91
left a comment
bikramSingh91
left a comment
There was a problem hiding this comment.
Looks good, just one nit.
Also, can you update the summary to include details about which new stats were added and an example of how they would look for a sample plan. Additionally, you can use that example to give more context on how these stats help fill in the gaps
spershin
added a commit
to spershin/velox-1
that referenced
this pull request
Apr 21, 2026
Summary: Operator stats have gaps and to suitable to determine where time went in a task. Adding driver timing stats per pipeline to assist in understanding a query bottlenecks. The current version does not handle the grouped execution well. Working on the extra to support grouped execution as well. Differential Revision: D101395498
spershin
force-pushed
the
export-D101395498
branch
from
3bec709 to
9c85143
Compare
spershin
changed the title
bikramSingh91
approved these changes
Apr 21, 2026
Summary: Operator stats have gaps and to suitable to determine where time went in a task. Adding driver timing stats per pipeline to assist in understanding a query bottlenecks. The current version does not handle the grouped execution well. Working on the extra to support grouped execution as well. Reviewed By: bikramSingh91 Differential Revision: D101395498
meta-codesync
Bot
changed the title
spershin
force-pushed
the
export-D101395498
branch
from
9c85143 to
68be145
Compare
spershin
changed the title
|
This pull request has been merged in 39843f2. |
shrshi
pushed a commit
to patdevinwilson/velox
that referenced
this pull request
Apr 23, 2026
Summary: Pull Request resolved: facebookincubator#17237 Operator stats have gaps and to suitable to determine where time went in a task. Adding driver timing stats per pipeline to assist in understanding a query bottlenecks. The current version does not handle the grouped execution well. Working on the extra to support grouped execution as well. Reviewed By: bikramSingh91 Differential Revision: D101395498 fbshipit-source-id: 1bd6e5311844f851109fd694afe37d101efe90a7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Operator stats have gaps and to suitable to determine where time went in a task.
Adding driver timing stats per pipeline to assist in understanding a query bottlenecks.
The current version does not handle the grouped execution well.
Working on the extra to support grouped execution as well.
Reviewed By: bikramSingh91
Differential Revision: D101395498