fix(cudf): Guard hash join build debug logging against empty inputs#17221
Closed
pramodsatya wants to merge 1 commit intofacebookincubator:mainfrom
Closed
fix(cudf): Guard hash join build debug logging against empty inputs#17221pramodsatya wants to merge 1 commit intofacebookincubator:mainfrom
pramodsatya wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
pramodsatya
requested review from
bdice,
devavret,
karthikeyann and
mhaseeb123
as code owners
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
Build Impact AnalysisFull build recommended. Files outside the dependency graph changed:
These directories are not fully covered by the dependency graph. A full build is the safest option. Fast path • Graph from main@560a4edaf3efb2b0f0071f9eaf07c32919b58b50 |
pramodsatya
force-pushed
the
fix-tpch-q16
branch
from
d0b5b45 to
05f80f0
Compare
pramodsatya
changed the title
jinchengchenghh
approved these changes
Apr 17, 2026
Contributor
jinchengchenghh
left a comment
jinchengchenghh
left a comment
There was a problem hiding this comment.
Thanks for your fix.
Please update your PR description, this only occurred in debug mode
devavret
approved these changes
Apr 17, 2026
Collaborator
Author
|
Thanks @jinchengchenghh @devavret, updated the PR description. Could you help get this merged? |
devavret
added
ready-to-merge
|
@peterenescu has imported this pull request. If you are a Meta employee, you can view this in D101671299. |
mhaseeb123
approved these changes
Apr 20, 2026
|
@peterenescu merged this pull request in 0187d5b. |
shrshi
pushed a commit
to patdevinwilson/velox
that referenced
this pull request
Apr 23, 2026
…acebookincubator#17221) Summary: When the build side of a hash join has no data (e.g. anti-join with empty result), inputs_ is empty. With a debug build, the logging at `noMoreInput()` accesses `inputs_[0]` without bound checking, which could result in a `SIGSEGV`. This fixes Q16 (TPC-H) which uses NOT IN (anti-join) where the build side can be empty for some partitions. Pull Request resolved: facebookincubator#17221 Reviewed By: kagamiori Differential Revision: D101671299 Pulled By: peterenescu fbshipit-source-id: 0971d85671e67810789d8148ce3891e757faf4f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the build side of a hash join has no data (e.g. anti-join with
empty result), inputs_ is empty. With a debug build, the logging at
noMoreInput()accessesinputs_[0]without bound checking,which could result in a
SIGSEGV.This fixes Q16 (TPC-H) which uses NOT IN (anti-join) where the build
side can be empty for some partitions.