perf(decode): Use reusable output for projection and decode#655
Open
srsuryadev wants to merge 1 commit intofacebookincubator:mainfrom
Open
perf(decode): Use reusable output for projection and decode#655srsuryadev wants to merge 1 commit intofacebookincubator:mainfrom
srsuryadev wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: New projection method that writes output into a reusable std::string, avoiding IOBuf chain construction and per-row allocation overhead. Uses memcpy with run-merging for the sorted fast path. Update SstBenchmarkReader to use the new method in all collectSstValue lambdas, eliminating IOBuf chain allocation and coalesce() in the decode pipeline. Differential Revision: D100113921
|
@srsuryadev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100113921. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
New projection method that writes output into a reusable std::string,
avoiding IOBuf chain construction and per-row allocation overhead.
Uses memcpy with run-merging for the sorted fast path.
Update SstBenchmarkReader to use the new method in all collectSstValue
lambdas, eliminating IOBuf chain allocation and coalesce() in the
decode pipeline.
Differential Revision: D100113921