Skip to content

fix: nimble failing test (#610) #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srsuryadev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: nimble failing test (#610) #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dwio/nimble/tablet/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,19 @@ target_link_libraries(

add_library(nimble_tablet_reader FileLayout.cpp TabletReader.cpp)
target_link_libraries(
nimble_tablet_reader nimble_tablet_common nimble_chunk_index_fb
nimble_tablet_reader
nimble_tablet_common
nimble_chunk_index_fb
)

add_library(
nimble_tablet_writer ChunkIndexWriter.cpp ClusterIndexWriter.cpp
TabletWriter.cpp
)
target_link_libraries(
nimble_tablet_writer nimble_tablet_common nimble_cluster_index_fb
nimble_tablet_writer
nimble_tablet_common
nimble_cluster_index_fb
nimble_chunk_index_fb
)

Expand Down
2 changes: 1 addition & 1 deletion dwio/nimble/velox/tests/VeloxWriterTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ TEST_F(VeloxWriterTest, featureReorderingStreamCollocation) {
auto tablet = nimble::TabletReader::create(&readFile, leafPool_.get(), {});
ASSERT_GE(tablet->stripeCount(), 1);
if (enableIndex) {
ASSERT_NE(tablet->index(), nullptr) << "Cluster index must exist";
ASSERT_NE(tablet->clusterIndex(), nullptr) << "Cluster index must exist";
}

auto stripeId = tablet->stripeIdentifier(0);
Expand Down
Loading