Skip to content

[style-value-parser] Fix BorderRadiusShorthand.toString dropping vertical radii #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeSingh1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[style-value-parser] Fix BorderRadiusShorthand.toString dropping vertical radii #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/style-value-parser/src/properties/__tests__/border-radius.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,4 +351,29 @@ describe('Test CSS property shorthand: `border-radius`', () => {
),
);
});

describe('serialization: `BorderRadiusShorthand.toString`', () => {
const roundTrip = (input: string): string =>
BorderRadiusShorthand.parse.parseToEnd(input).toString();

test('symmetric radii serialize without a `/`', () => {
expect(roundTrip('10px')).toBe('10px');
expect(roundTrip('10px 20px')).toBe('10px 20px');
expect(roundTrip('10px 20px 30px')).toBe('10px 20px 30px');
expect(roundTrip('10px 20px 30px 40px')).toBe('10px 20px 30px 40px');
});

test('asymmetric radii keep the vertical values after the `/`', () => {
// Regression: the vertical (post-slash) radii were previously rendered
// using the horizontal values, which collapsed the whole value back to
// the horizontal radii and dropped the vertical radii entirely.
expect(roundTrip('10px 20px 30px 40px / 40px 30px 20px 10px')).toBe(
'10px 20px 30px 40px / 40px 30px 20px 10px',
);
expect(roundTrip('10px / 20px')).toBe('10px / 20px');
expect(roundTrip('10px 20px / 30px 40px')).toBe(
'10px 20px / 30px 40px',
);
});
});
});
2 changes: 1 addition & 1 deletion packages/style-value-parser/src/properties/border-radius.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class BorderRadiusShorthand {
const verticalBottomRight = this.verticalBottomRight.toString();
const verticalBottomLeft = this.verticalBottomLeft.toString();

let sStr = `${horizontalTopLeft} ${horizontalTopRight} ${horizontalBottomRight} ${horizontalBottomLeft}`;
let sStr = `${verticalTopLeft} ${verticalTopRight} ${verticalBottomRight} ${verticalBottomLeft}`;
// All three are the same
if (
verticalTopLeft === verticalTopRight &&
Expand Down