Pass VERBOSE=1 to make check so failed test logs are dumped - #988
Closed
xuhdev wants to merge 1 commit into
Closed
Conversation
Summary: Automake's parallel test harness only prints `PASS:`/`FAIL:` summaries by default. When a test fails on the GitHub CI runner, the actual error message lives in `test/unit/test-suite.log` (and the per-test `.log` files), which we never get to see because the harness just points at them and exits. Setting `VERBOSE=1` tells the harness to dump those logs to stdout after the summary, so a failure like the recent `clinit_batching_pass_test` regression shows the real output directly in the GitHub Actions log. `V=1` is also passed so any incidental rebuild output is shown in full rather than via silent rules. Differential Revision: D102907004
|
@xuhdev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102907004. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Automake's parallel test harness only prints
PASS:/FAIL:summaries by default. When a test fails on the GitHub CI runner, the actual error message lives intest/unit/test-suite.log(and the per-test.logfiles), which we never get to see because the harness just points at them and exits.Setting
VERBOSE=1tells the harness to dump those logs to stdout after the summary, so a failure like the recentclinit_batching_pass_testregression shows the real output directly in the GitHub Actions log.V=1is also passed so any incidental rebuild output is shown in full rather than via silent rules.Differential Revision: D102907004