Fix unused parameter warnings in HostPlatformViewTraitsInitializer.h (#56491)#56491
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Fix unused parameter warnings in HostPlatformViewTraitsInitializer.h (#56491)#56491christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101108434. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
d9963d8 to
76e0ab1
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
76e0ab1 to
3c82169
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
2 times, most recently
from
5596077 to
a9add81
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Differential Revision: D101108434
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
a9add81 to
195f8fe
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
195f8fe to
a348742
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
a348742 to
cf7c7c8
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
cf7c7c8 to
ab92fab
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
ab92fab to
3326b64
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
3326b64 to
10ab1f7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
10ab1f7 to
4a93988
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
4a93988 to
0bb100e
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
0bb100e to
76c58c0
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
76c58c0 to
425874d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
425874d to
bc13e2d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
bc13e2d to
2a4b38c
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
2a4b38c to
3ad5807
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56491) Summary: Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
3ad5807 to
ac3db17
Compare
…acebook#56491) Summary: Pull Request resolved: facebook#56491 Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility. Changes: - `formsStackingContext`: Commented out unused 'props' parameter - `formsView`: Commented out unused 'props' parameter - `isKeyboardFocusable`: Already had parameter commented out correctly Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101108434
christophpurrer
force-pushed
the
export-D101108434
branch
from
ac3db17 to
70e54bc
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in eed1e34 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in eed1e34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed clang-diagnostic-unused-parameter warnings in HostPlatformViewTraitsInitializer.h by commenting out unused parameter names while maintaining API compatibility.
Changes:
formsStackingContext: Commented out unused 'props' parameterformsView: Commented out unused 'props' parameterisKeyboardFocusable: Already had parameter commented out correctlyChangelog: [Internal]
Reviewed By: zeyap
Differential Revision: D101108434