Skip to content

Fix unused parameter warnings in IMountingManager.h (#56488) #56488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
+18 −15
Closed

Fix unused parameter warnings in IMountingManager.h (#56488) #56488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions packages/react-native/ReactCxxPlatform/react/renderer/uimanager/IMountingManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,29 +40,32 @@ class IMountingManager {
virtual void
dispatchCommand(const ShadowView &shadowView, const std::string &commandName, const folly::dynamic &args) = 0;

virtual void setIsJSResponder(const ShadowView &shadowView, bool isJSResponder, bool blockNativeResponder) {};
virtual void
setIsJSResponder(const ShadowView & /* shadowView */, bool /* isJSResponder */, bool /* blockNativeResponder */)
{
}

virtual void synchronouslyUpdateViewOnUIThread(Tag reactTag, const folly::dynamic &changedProps) {};
virtual void synchronouslyUpdateViewOnUIThread(Tag /* reactTag */, const folly::dynamic & /* changedProps */) {}

virtual void onUpdateShadowTree(const std::unordered_map<Tag, folly::dynamic> &tagToProps) {};
virtual void onUpdateShadowTree(const std::unordered_map<Tag, folly::dynamic> & /* tagToProps */) {}

virtual void initializeAccessibilityManager() {};
virtual void initializeAccessibilityManager() {}

virtual void setAccessibilityFocusedView(Tag viewTag) {};
virtual void setAccessibilityFocusedView(Tag /* viewTag */) {}

virtual void setFocusedView(Tag viewTag) {};
virtual void setFocusedView(Tag /* viewTag */) {}

virtual void clearAccessibilityFocusedView(Tag viewTag) {};
virtual void clearAccessibilityFocusedView(Tag /* viewTag */) {}

virtual void accessibleClickAction(Tag viewTag) {};
virtual void accessibleClickAction(Tag /* viewTag */) {}

virtual void accessibleScrollInDirection(Tag viewTag, int direction) {};
virtual void accessibleScrollInDirection(Tag /* viewTag */, int /* direction */) {}

virtual void accessibleSetText(Tag viewTag, const std::string &text) {};
virtual void accessibleSetText(Tag /* viewTag */, const std::string & /* text */) {}

virtual void clearFocusedView(Tag viewTag) {};
virtual void clearFocusedView(Tag /* viewTag */) {}

virtual void setAfterMountCallback(std::function<void(SurfaceId)> &&onAfterMount) {};
virtual void setAfterMountCallback(std::function<void(SurfaceId)> && /* onAfterMount */) {}

virtual ComponentRegistryFactory getComponentRegistryFactory()
{
Expand All @@ -74,11 +77,11 @@ class IMountingManager {
return false;
}

virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor &&schedulerTaskExecutor) noexcept {};
virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor && /* schedulerTaskExecutor */) noexcept {}

virtual void setEventEmitterListener(std::shared_ptr<EventEmitterListener> listener) noexcept {};
virtual void setEventEmitterListener(std::shared_ptr<EventEmitterListener> /* listener */) noexcept {}

virtual void setUIManager(std::weak_ptr<UIManager> uiManager) noexcept {};
virtual void setUIManager(std::weak_ptr<UIManager> /* uiManager */) noexcept {}

virtual std::shared_ptr<IImageLoader> getImageLoader() noexcept
{
Expand Down
Loading