Skip to content

Automatically set --runInBand when running benchmarks #56436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubennorte wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

Automatically set --runInBand when running benchmarks #56436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df95d86
Skip reporting benchmark results in test mode
rubennorte Apr 14, 2026
aa03ec0
Automatically set --runInBand when running benchmarks
rubennorte Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion private/react-native-fantom/src/Benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@ export function suite(
'Failing focused test to prevent it from being committed',
);
}
reportBenchmarkResult(createBenchmarkResultsObject(bench, tasks));
if (!isTestOnly) {
reportBenchmarkResult(createBenchmarkResultsObject(bench, tasks));
}
});

const test = (name: string, fn: SyncFn, options?: FnOptions): SuiteAPI => {
Expand Down
4 changes: 4 additions & 0 deletions scripts/fantom.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,8 @@ for arg in "$@"; do
esac
done

if [[ -n "$FANTOM_RUN_BENCHMARKS" ]]; then
ARGS+=("--runInBand")
fi

yarn jest --config private/react-native-fantom/config/jest.config.js "${ARGS[@]}"
Loading