Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyrefly/lib/lsp/wasm/completion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1194,14 +1194,18 @@ impl Transaction<'_> {
let expression_only =
matches!(context, IdentifierContext::Expr(_)) && !at_statement_start;
Self::add_keyword_completions(handle, expression_only, &mut result);
let local_completion_start = result.len();
let has_local_completions = self.add_local_variable_completions(
handle,
Some(&identifier),
position,
expected_type.as_ref(),
&mut result,
);
if auto_import && !has_local_completions {
let has_prefix_local_completion = result[local_completion_start..]
.iter()
.any(|completion| completion.item.label.starts_with(identifier.as_str()));
if auto_import && !has_prefix_local_completion {
self.add_autoimport_completions(
handle,
&identifier,
Expand Down
34 changes: 34 additions & 0 deletions pyrefly/lib/test/lsp/completion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2457,6 +2457,40 @@ Completion Results:
);
}

#[test]
fn autoimport_completion_not_blocked_by_fuzzy_local_symbol() {
let code = r#"
def avg_kendall_tau(): ...

kendalltau
# ^
"#;
let files = [("main", code), ("scipy.stats", "def kendalltau(): ...\n")];
let (handles, state) = mk_multi_file_state(&files, Require::Exports, false);
let handle = handles.get("main").unwrap();
let position = extract_cursors_for_test(code)[0];
let completions =
state
.transaction()
.completion(handle, position, ImportFormat::Absolute, true, None);
let autoimport = completions
.iter()
.find(|item| item.label == "kendalltau")
.expect("expected kendalltau auto-import completion");
assert!(
autoimport.additional_text_edits.is_some(),
"expected auto-import edit, got {autoimport:?}"
);
assert!(
autoimport
.detail
.as_ref()
.is_some_and(|detail| detail.contains("from scipy.stats import kendalltau")),
"expected scipy.stats import detail, got {:?}",
autoimport.detail
);
}

#[test]
fn autoimport_common_alias_for_module() {
let code = r#"
Expand Down
Loading