Skip to content

fix Add hover info for language keywords #4340 - #4372

Open
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:4340
Open

fix Add hover info for language keywords #4340#4372
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:4340

Conversation

@asukaminato0721

@asukaminato0721 asukaminato0721 commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #4340

see this from r-a, so impl it here.

Added documentation and Python language-reference links for language keywords.
Preserved existing type-aware hover information for operators such as in, not, is, and, and or.
Distinguished keywords with multiple grammatical roles:

  • Iteration in shows iteration-specific documentation and the inferred iterable type.
  • Membership in / not in shows membership-test documentation and __contains__ information.
  • Compound forms such as is not, yield from, and raise ... from show their specific documentation.
  • Context-sensitive keywords including from, if, else, for, as, and async select documentation based on their enclosing AST node.

Added support for the Python 3.15 lazy soft keyword, while avoiding hover results when lazy is used as an identifier or module name.

Test Plan

Added regression tests for keyword roles, compound operators, iteration versus membership, soft keywords, and lazy imports.

@meta-codesync

meta-codesync Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D114172308. (Because this pull request was imported automatically, there will not be any future comments.)

@codspeed-hq

codspeed-hq Bot commented Jul 30, 2026

Copy link
Copy Markdown

Unable to generate the flame graphs

The performance report has correctly been generated, but there was an internal error while generating the flame graphs for this run. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists.

@github-actions

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hover info for language keywords

2 participants