fix Add hover info for language keywords #4340 - #4372
Open
asukaminato0721 wants to merge 1 commit into
Open
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D114172308. (Because this pull request was imported automatically, there will not be any future comments.) |
Unable to generate the flame graphsThe performance report has correctly been generated, but there was an internal error while generating the flame graphs for this run. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4340
see this from r-a, so impl it here.
Added documentation and Python language-reference links for language keywords.
Preserved existing type-aware hover information for operators such as in, not, is, and, and or.
Distinguished keywords with multiple grammatical roles:
__contains__information.Added support for the Python 3.15 lazy soft keyword, while avoiding hover results when lazy is used as an identifier or module name.
Test Plan
Added regression tests for keyword roles, compound operators, iteration versus membership, soft keywords, and lazy imports.