You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Requests received while awaiting_initial_workspace_config is set are now held and re-enqueued once the response lands. Checking that flag in make_handle_if_enabled instead, as the issue suggests, would return empty responses during startup for everyone, not just those who disabled language services. Releasing is keyed on the request method rather than on a successful parse, so a client that fails the configuration request stops us waiting too.
The middleware no longer waits for the Python extension. It uses a new non-blocking getInterpreterPathIfResolved, and activate re-pulls the configuration once the interpreter resolves, since onDidChangeInterpreter only fires on a later change.
This pull request has been imported. If you are a Meta employee, you can view this in D114050960. (Because this pull request was imported automatically, there will not be any future comments.)
The performance report has correctly been generated, but there was an internal error while generating the flame graphs for this run. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requests received while
awaiting_initial_workspace_configis set are now held and re-enqueued once the response lands. Checking that flag inmake_handle_if_enabledinstead, as the issue suggests, would return empty responses during startup for everyone, not just those who disabled language services. Releasing is keyed on the request method rather than on a successful parse, so a client that fails the configuration request stops us waiting too.The middleware no longer waits for the Python extension. It uses a new non-blocking
getInterpreterPathIfResolved, andactivatere-pulls the configuration once the interpreter resolves, sinceonDidChangeInterpreteronly fires on a later change.Fixes #4332
Test Plan
Regression tests added, for both a successful and a failed configuration response.