buckconfig/watchmanconfig: ignore jj directory & cargo#1308
Open
lf- wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103477756. (Because this pull request was imported automatically, there will not be any future comments.) |
Neither of the configurations were actually ignoring these things; it's necessary to duplicate exclusions in both to stop the internal (fallback) file watcher from emitting junk into DICE, even though the excludes in it don't affect the internal watcher itself (it still sets inotify on the directories unconditionally).
lf-
force-pushed
the
jade/push-xpkwsmmqnqzn
branch
from
8c11037 to
d819424
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither of the configurations were actually ignoring these things; it's necessary to duplicate exclusions in both to stop the internal (fallback) file watcher from emitting junk into DICE, even though the excludes in it don't affect the internal watcher itself (it still sets inotify on the directories unconditionally).