custom event metadata from buckconfig#1299
Open
KlotzAndrew wants to merge 1 commit into
Open
Conversation
dont modify pool.rs cleanup
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D101692996. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadata.rs current has a number of metadata fields added to buck2 log events, these are hardcoded and some are specific to meta. This change supports adding arbitrary metadata to buck2 event uploads, for any user to configure though their .buckconfig:
Example
.buckconfig
meant to be paired with something like this to upload logs: #1296