Propagate linker_type correctly in the system_cxx_toolchain#1295
Propagate linker_type correctly in the system_cxx_toolchain#1295Nehliin wants to merge 2 commits into
system_cxx_toolchain#1295Conversation
|
Hi @Nehliin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Previously the system cxx toolchain would hard code the linker type based off the os. This works fine in most cases but breaks windows gnu builds for example. The
linker_typeis already correctly provided by theCxxToolsInfotype but ignored. This pr uses the linker_type from there instead and adds a select to the path clang tools to separate darwin from gnu targets.