fix: [JS/TS/Tests] Remove mocha to resolve package vulnerabilities#4604
Merged
Conversation
ncave
changed the title
ncave
force-pushed
the
mocha
branch
6 times, most recently
from
2b21243 to
80ca8ff
Compare
ncave
changed the title
ncave
force-pushed
the
mocha
branch
3 times, most recently
from
19d761a to
126eae3
Compare
Collaborator
Author
|
A bit strange (cause it works fine locally), I had to bump Node version to be able to disable test isolation to make this one test pass in CI (technically, test order randomization also makes it pass somehow). Ready for merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.