Release/1.6.8 (DO NOT MERGE) - #862
Draft
lee00678 wants to merge 3 commits into
Draft
Conversation
…ced @vue-ignore annotation (#855) Since 1.6.5, the Vue wrappers for the three "complex prop" components (Crosshair, Timeline, Boxplot) compiled with no runtime props at all, so their own `data` prop was silently ignored: `props.data` was always undefined and, for example, the crosshair tooltip template received `undefined` unless data was set on the container instead. Root cause: commit d4a22d2 changed the autogen output from an interface-extends pattern to an inline intersection with the ignore annotation in front: defineProps</** @vue-ignore */ Config<Datum> & { data?: Datum[] }>() Babel attaches a leading comment at the start of a type to the whole TSIntersectionType node, and @vue/compiler-sfc checks for @vue-ignore on a node before recursing into its members - so the entire type, including { data?: Datum[] }, resolved to zero props. Fix: reorder the intersection so the annotation attaches only to the config member: defineProps<{ data?: Datum[] } & /** @vue-ignore */ Config<Datum>>() The compiled components now declare `props: { data: {} }` again, byte-identical to the 1.6.4 output, while config props keep flowing through as fallthrough attrs (which useForwardProps reads from attrs). The emitted d.ts still exposes the full Config<Datum> & { data } typing. Note: reverting to the 1.6.4 interface-extends form is not possible - current vue-tsc fails it with TS4082 (private name 'Props' in the default export), which is the build error that motivated d4a22d2. The reordered intersection avoids both problems. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a release branch for a patch (1.6.8)
Cherry pick #857 into 1.6.7 branch.
Removed packages/vue/src/components/boxplot/index.vue as the component is not available yet.
I don't think we should merge this into main
Have not released yet.