[btrappe]

Closes #25

What

Automated tests: Jest + jsdom, 47 tests, 98% line coverage

• The tests load the real taskpane.html and run taskpane.ts against:
  • a fake Office.js (test/helpers/office.ts), with asynchronous callbacks like the real API, and
  • a fake <ezp-printing> (test/helpers/ezpPrinting.ts), which records every property write so ordering can be asserted.
• Covered:
  • start-up, signed in and signed out
  • <ezp-printing> defined late or never (15 s timeout)
  • multi-slice PDF export: order, closed once, 9 MB document, bytes > 127
  • every error path shows a message instead of an endless spinner
  • Word on the web, Excel on the web, PowerPoint, legacy Edge
  • Excel empty sheet; file name from a local path, a SharePoint URL or an unsaved document
  • reprint, including the filedata watcher reset
  • sign-in dialog: start URL, sizes, code, error, non-JSON message, user close 12006, open failure; single-use code cleared
  • redirect page and its open-redirect guard (look-alike hosts, userinfo trick, javascript:)
  • logout and German texts
• The tests catch real regressions.
  • Against the pre-fix(taskpane): align add-in flow with Office.js docs, fix endless spinner #16 code, 29 of the 30 task pane tests fail.
  • I reverted four key fixes one at a time; each reversion made at least one test fail: the whenDefined wait, filename before filedata, the filedata reset, and the dialog status check.

CI: .github/workflows/test.yml

• Runs npm run lint, npm run typecheck, npm run test:coverage and npm run build on every pull request, on Node 18 like the release build.
• Uploads the coverage report as an artifact.
• Has read-only permissions and never deploys. node.js.yml is unchanged.

Documentation: TESTING.md (linked from the README)

• How the harness works, a coverage map linked to Word on the web: no PDF export via Office.js — decide on approach #17, ezeep-js: open() always shows sign-in dialog; uses window.open inside Office add-ins #18, Pin ezeep-js to a versioned CDN path #19, Manifest: declare <Requirements> (File/PdfFile, DialogApi) #20 and Task pane stuck on endless loading spinner #24, and how to write a new test.
• What the automated tests don't cover.
• A manual end-to-end plan: prerequisites, sideloading per platform, debugging (Windows Inspect, Mac Web Inspector defaults commands, cache clearing), and a 12-case matrix over Word/Excel × Windows/Mac/web.

Small source change

• authRedirect.ts now exports isAllowedAuthUri, resultMessage and handleAuthRedirect (with injectable navigation) so it can be tested.
• Runtime behaviour is unchanged.

Tooling

• npm scripts test, test:coverage and typecheck.
• test/tsconfig.json, an ESLint override for test files, and a root tsconfig.json that excludes test/ and jest.config.js. Before that, tsc -p . picked up Jest's typings through allowJs.
• coverage/ is gitignored.
• New dev dependencies: jest@29, jest-environment-jsdom@29, babel-jest@29, @babel/preset-env@7, @types/jest@29.
• The lockfile stays on v2 and the node-forge override from chore(deps): override node-forge to >=1.4.0 (Dependabot) #15 is kept.
• @babel/preset-env requires Babel core 7.29 (from 7.21), plus minor transitive bumps.
• npm audit against main: no new advisories; 4 fewer, including the critical @babel/traverse one.

Verification

• Clean npm ci, then lint, type check (app and tests), 47/47 tests and production build: all pass locally.
• The new workflow should run on this PR. It's the first time it runs on GitHub, so please check that it shows up.

Note on #16

This content was first pushed to feature/office-api-review-fixes after #16 had already been merged. That commit (f0242b4) is not on main, and that branch can be deleted. This PR carries the same content, rebuilt on current main.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CKAReNgzxtfL9PsLuthKK1

---

Generated by Claude Code