Skip to content

Adding verification that sess.cookie is set #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brismuth wants to merge 7 commits into
base: master
Choose a base branch
from
+76 −3
Open

Adding verification that sess.cookie is set #904

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c45fdf8
Adding verification that sess.cookie is set
brismuth Jul 28, 2022
6057549
Returning an error when sess.cookie is not set
brismuth Jul 28, 2022
bb777ad
Adding corrupt session test
Jul 28, 2022
1f6f524
Expanding error handling for all kinds of corrupt sessions
Jul 28, 2022
c0a79e0
Updating test to pass on all node versions
Jul 29, 2022
bbac326
Moving assert.match to assert.ok
Jul 29, 2022
c9cd25a
Adds corrupt session handling for .reload()
Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion session/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Store.prototype.load = function(sid, fn){
var self = this;
this.get(sid, function(err, sess){
if (err) return fn(err);
if (!sess) return fn();
if (!sess || !sess.cookie) return fn();
var req = { sessionID: sid, sessionStore: self };
fn(null, self.createSession(req, sess))
});
Expand Down