Repository navigation
Conversation
Contributor
|
Duplicate of #7533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
req.subdomainssplits any dotted host on., but an IPv6 literal can legitimately contain dots — for example the IPv4-mapped address[::ffff:127.0.0.1]. The bracketed host fails theisIP()check (which does not accept brackets), so it is treated as a hostname and shredded:[::1]worked only by accident, because it contains no dots.Fix
Strip the surrounding brackets of an IPv6 literal before the
isIP()check so the host is recognized as an IP address and never split. The IP branch keeps returning the hostname as-is, so behavior for[::1]and plain IPv4/IPv6 hosts is unchanged.Tests
Added a case for
Host: [::ffff:127.0.0.1]→[]intest/req.subdomains.js; the existing IPv4/IPv6/hostname cases are unchanged.Fixes #7532.