Repository navigation
Conversation
req.hostname keeps the brackets of an IPv6 literal (e.g. [::ffff:127.0.0.1]), and net.isIP() returns 0 for the bracketed form, so the host fell into the domain branch and was split on its dots, giving ["0", "[::ffff:127"] instead of []. Detect the brackets and keep the literal as a single unit. Closes expressjs#7532
Contributor
|
Duplicate of #7533 |
Author
|
Right, #7533 beat me to it by a day — same fix either way. Thanks for the quick review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
req.hostnamekeeps the brackets of an IPv6 literal (e.g.[::ffff:127.0.0.1]), andnet.isIP()returns0for the bracketed form — so the host fell into the domain branch and got split on its dots, producing["0", "[::ffff:127"]instead of[]. Detect the brackets and keep the literal as a single unit.req.subdomainsnow treats any bracketed hostname as one unit, never split on dots[::1], domain hosts, andsubdomain offsetbehavior are unchanged (existing tests pass)Closes #7532