Repository navigation
fix(response): keep custom Content-Type values in res.set() - #7537
Closed
princejain756 wants to merge 1 commit into
Closed
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
mime.contentType() returns false for an unrecognized slashless value such as 'some-custom-type', and res.set() then wrote the literal header value 'false'. The original string is kept when lookup fails. Fixes expressjs#7034
Contributor
|
Duplicate of #7035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res.set('Content-Type', 'some-custom-type')sentContent-Type: false:mime.contentType()returnsfalsefor an unrecognized slashless value and the boolean was written straight to the header.The lookup result now falls back to the caller's string, matching the behavior the issue asks for. Values that already contain
/and known type names are unchanged.Fixes #7034