Repository navigation
fix(request): do not split bracketed IPv6 hosts into subdomains - #7536
Closed
princejain756 wants to merge 1 commit into
Closed
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
req.hostname keeps the brackets of an IPv6 literal such as [::ffff:127.0.0.1], and net.isIP rejects the bracketed form, so req.subdomains dot-split the address into bogus parts like ["0", "[::ffff:127"]. The isIP check now runs on the unbracketed address; the subdomains value still reports the host as written. Fixes expressjs#7532
Contributor
|
Duplicate of #7533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
req.subdomainssplit an IPv6 host containing dots.req.hostnamekeeps the brackets of an IPv6 literal ([::ffff:127.0.0.1]), andnet.isIP()rejects the bracketed form, so the address was treated as a domain name and dot-split:isIPnow runs on the unbracketed address; the returned subdomains still report the host as written.[::1]and IPv4 behavior unchanged (13 subdomains tests + full suite green).Fixes #7532