Add test metadata - #373
Conversation
|
When you merge a PR that touches a test file, you can control whether or not the tests are rerun with the commit message. They aren't always rerun. I suspect the number of solutions on this track is low enough that a rerun wouldn't be a big deal. |
|
These 10 are missing a
These 14 are missing a
These 3 have a
Of these 27, I believe |
|
For what it's worth, incorrectly tests the sum of squares method by calling the square of sum method. Given the expected return value is 1 either way, this passes the CI even though the test suite is incorrect. |
|
I don't want to add new test. That's why they are marked as "included = false". I want this PR to have no impact to users on any existing solutions. So no rerun of tests. Just added metadata. How do I make sure of this? PS: if there are bugs in tests, separate issue or PR, please |
|
https://exercism.org/docs/building/tracks#h-avoiding-triggering-unnecessary-test-runs At the moment, this PR won't rerun solutions since you're not touching any important files. The No important files changed workflow will trigger and alert you though if you're in a situation where solutions will be rerun by default. At that point, you can manually opt out of rerunning solutions for that PR. |
|
Thanks. So we just need someone to approve and then merge 🙏 |
Closes #358
@IsaacG if we add tests to an exercise (change the
zcl_...clas.testclasses.abapfile), does it invalidate the solutions for all users? If it does I don't think we will make those changes since we have pretty good test coverage.Missing tests
10 exercises have missing tests, totaling 50 tests (
include = false, not superseded by another case).47 exercises scanned, 616 total test cases.