chore: remove unused root package.json and lockfile#241
Conversation
The root package.json (sun-valley) was an accidental npm init -y added in the client impl commit (933d335). It has the default index.js main with no index.js, the npm init test stub, and is not referenced by CI, Dockerfiles, scripts or any workspace config. The actual npm code lives in clients/ and bin/sponsor-service/, each with its own package.json. Removing the orphan manifest also stops spurious Dependabot alerts on dependencies nothing uses.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe entire Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Deletes the root
package.json(sun-valley) andpackage-lock.json.Why
These were added by an accidental
npm init -y+npm install viemin the client impl commit (933d335). Evidence they are unused:mainpoints toindex.jswhich does not existtestscript is the literalnpm initstub (echo "Error: no test specified" && exit 1)clients/(unit.ymlworking-directory: clients,e2e.ymlcd clients), never at the repo rootclients/(@evstack/evnode-viem) andbin/sponsor-service/, each with its ownpackage.jsonRemoving the orphan manifest also stops spurious Dependabot security PRs/alerts (e.g. #fefd86145f) against dependencies nothing in the repo actually uses.
Note
This supersedes the Dependabot npm bump PR, which was only touching this dead manifest.
Summary by CodeRabbit