Skip to content

chore: remove unused root package.json and lockfile#241

Merged
randygrok merged 2 commits into
mainfrom
chore/remove-unused-root-package
May 20, 2026
Merged

chore: remove unused root package.json and lockfile#241
randygrok merged 2 commits into
mainfrom
chore/remove-unused-root-package

Conversation

@randygrok
Copy link
Copy Markdown
Contributor

@randygrok randygrok commented May 19, 2026

What

Deletes the root package.json (sun-valley) and package-lock.json.

Why

These were added by an accidental npm init -y + npm install viem in the client impl commit (933d335). Evidence they are unused:

  • main points to index.js which does not exist
  • test script is the literal npm init stub (echo "Error: no test specified" && exit 1)
  • CI runs npm only inside clients/ (unit.yml working-directory: clients, e2e.yml cd clients), never at the repo root
  • No Dockerfile / Makefile / scripts / workspace (pnpm/turbo/lerna/nx) config references it
  • The real npm code lives in clients/ (@evstack/evnode-viem) and bin/sponsor-service/, each with its own package.json

Removing the orphan manifest also stops spurious Dependabot security PRs/alerts (e.g. #fefd86145f) against dependencies nothing in the repo actually uses.

Note

This supersedes the Dependabot npm bump PR, which was only touching this dead manifest.

Summary by CodeRabbit

  • Chores
    • Removed project build configuration metadata and package dependencies.

The root package.json (sun-valley) was an accidental npm init -y added in
the client impl commit (933d335). It has the default index.js main with no
index.js, the npm init test stub, and is not referenced by CI, Dockerfiles,
scripts or any workspace config. The actual npm code lives in clients/ and
bin/sponsor-service/, each with its own package.json. Removing the orphan
manifest also stops spurious Dependabot alerts on dependencies nothing uses.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 39dcfc34-4a27-4330-9c7c-63ded9c43d0d

📥 Commits

Reviewing files that changed from the base of the PR and between c646132 and 734c6dd.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json
💤 Files with no reviewable changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The entire package.json file was deleted. This removes all npm package metadata including the package name, version, description, entry points, license type, and the viem dependency declaration. No replacement configuration is present.

Changes

Cohort / File(s) Summary
Package Configuration Removal
package.json
File completely deleted, removing npm metadata and the viem dependency (^2.45.0).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 A package once lived in this repo with care,
With viem and metadata floating in air,
But now it's been deleted, gone without trace—
Did they move it elsewhere, or leave this place?
Questions abound in this deletion affair! 📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: removing an unused root package.json and lockfile.
Description check ✅ Passed The description comprehensively explains what was deleted, why it was unused, and provides clear evidence. It addresses the Type of Change (chore/refactoring) and includes relevant context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-unused-root-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@randygrok randygrok enabled auto-merge (squash) May 19, 2026 17:27
@randygrok randygrok merged commit b2dbcd0 into main May 20, 2026
19 checks passed
@randygrok randygrok deleted the chore/remove-unused-root-package branch May 20, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants