Skip to content

feat(syncing): detect sequencer double-signs and halt with persisted … #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CaelRowley wants to merge 19 commits into
base: main
Choose a base branch
from

Merge branch 'main' into cael/feat/double-sign-detection

e2e520b
Select commit
Loading
Failed to load commit list.
Open

feat(syncing): detect sequencer double-signs and halt with persisted … #3310

Merge branch 'main' into cael/feat/double-sign-detection
e2e520b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 20, 2026 in 1s

60.91% (+0.05%) compared to 53c5669

View this Pull Request on Codecov

60.91% (+0.05%) compared to 53c5669

Details

Codecov Report

❌ Patch coverage is 67.40088% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.91%. Comparing base (53c5669) to head (e2e520b).

Files with missing lines Patch % Lines
types/double_sign_evidence.go 0.00% 60 Missing ⚠️
block/internal/syncing/syncer.go 55.55% 5 Missing and 3 partials ⚠️
block/internal/cache/manager.go 94.59% 2 Missing ⚠️
block/internal/syncing/doublesign.go 97.33% 1 Missing and 1 partial ⚠️
pkg/store/keys.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3310      +/-   ##
==========================================
+ Coverage   60.86%   60.91%   +0.05%     
==========================================
  Files         127      129       +2     
  Lines       13762    13963     +201     
==========================================
+ Hits         8376     8506     +130     
- Misses       4474     4543      +69     
- Partials      912      914       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov