refactor: add new logger without a global state#1385
Draft
mrexox wants to merge 10 commits intoevilmartians:masterfrom
Draft
refactor: add new logger without a global state#1385mrexox wants to merge 10 commits intoevilmartians:masterfrom
mrexox wants to merge 10 commits intoevilmartians:masterfrom
Conversation
aee141d to
3cb55a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Current
internal/logimplementation is kinda mess. Need to change the app to have injectable logger instead of a global logger + state and colors management.Also move all printing-related logic into the
loggerpackage.Changes
logger.Loggertypelogpackage and replace all the calls withlogger.Logger