Merged
Conversation
Limit selectable text to user-copyable detail values instead of enabling it on section labels and other UI chrome. Keep titles, summaries, alternate title values, and media metadata values selectable while leaving structural headings and field labels non-selectable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Detail views had no consistent way to copy useful text such as titles, summaries, alternate titles, and media metadata values. The first pass also made some structural labels selectable, which added noise without helping copy workflows.
Approach
Limit text selection to the values users are likely to copy and keep section headings and field labels as normal UI text. This keeps the interaction focused on real content instead of exposing selection affordances on decorative labels.
Scope
Validation
make formatmake build