Skip to content

Add inputs and outputs to the graph#45

Open
trams wants to merge 1 commit into
etsy:masterfrom
criteo-forks:inputs_output_graph
Open

Add inputs and outputs to the graph#45
trams wants to merge 1 commit into
etsy:masterfrom
criteo-forks:inputs_output_graph

Conversation

@trams

@trams trams commented Feb 13, 2017

Copy link
Copy Markdown
Contributor

This is an attempt to show inputs and outputs in the flow diagram.

It is not very pretty. For one I didn't add any pictures for sources and sinks.
Also it contains a hack to filter __pipeX__pipeY outputs which may not work on your cluster

Apart from this it works perfectly and makes the diagram much more useful, especially for one step jobs.

Change-Id: Id153bf3975a304047e574b57fd66399c227aaf04
@dossett

dossett commented Apr 20, 2017

Copy link
Copy Markdown
Contributor

@trams Thank you for your many recent PRs! I merged a couple of them already, and will come back to the others after we get 1.1 released.

@trams

trams commented Apr 20, 2017

Copy link
Copy Markdown
Contributor Author

@dossett thanks! I'll wait for 1.1 and then try to rebase

@nixsticks

nixsticks commented Jul 7, 2017

Copy link
Copy Markdown
Contributor

Hey @trams, thank you for all the contributions you've made! This is a great idea but I'm hesitant because it makes graphs of moderate or larger size look quite unwieldy. If you have thoughts on how to improve the UX on that, we'd love to hear them.

@trams

trams commented Jul 7, 2017

Copy link
Copy Markdown
Contributor Author

Just out of curiosity what is the size of moderate graph? Most of our jobs contain around 3-5 steps and it look okayish (I didn't look for a proper picture for input|output)

@nixsticks

nixsticks commented Jul 7, 2017

Copy link
Copy Markdown
Contributor

@trams Many of our jobs are much larger than yours it sounds like -- a moderately-sized one would be around 10-15 steps for us(!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants