fix(slot-detail): prefer canonical block when slot has competing fork#434
Merged
Conversation
fct_block_head and fct_block can return multiple rows for a slot when a fork produces a competing block (canonical + orphaned). Row order from the API is non-deterministic, so data.blockHead[0] sometimes pointed at the orphan and the slot detail page rendered the wrong block_root. Sort both arrays canonical-first inside the hook so all consumers using [0] pick the canonical row. FctBlockHead lacks a status field, so the canonical block_root from fct_block is used to identify its match.
mattevans
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorts canonical first in the slot detail data hook when
fct_block_headandfct_blockreturn multiple rows for a slot. The slot page now shows the canonicalblock_rootinstead of sometimes picking the orphan, which depended on whichever row order the API happened to return.Reproduces on slot 13640826: pre-fix the page rendered
0x1fe6d769…(orphan, proposer 340513, EL block 24408745); post-fix it renders0x6bb4d0df…(canonical, proposer 2132049, EL block 24408804).