Skip to content

rpc: get error code/data from wrapped error #34886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmikolajczyk41 wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −4
Open

rpc: get error code/data from wrapped error #34886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c5136b
Use errors.As
pmikolajczyk41 May 6, 2026
c471e3c
Take data from the same object
pmikolajczyk41 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions rpc/json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,12 @@ func errorMessage(err error) *jsonrpcMessage {
Code: errcodeDefault,
Message: err.Error(),
}}
ec, ok := err.(Error)
if ok {
msg.Error.Code = ec.ErrorCode()
var rpcError Error
if errors.As(err, &rpcError) {
msg.Error.Code = rpcError.ErrorCode()
}
de, ok := err.(DataError)
// Type assert on rpcError to ensure that both code and data come from the same error object.
de, ok := rpcError.(DataError)
if ok {
msg.Error.Data = de.ErrorData()
}
Expand Down
Loading