refactor(spec): use uint32 instead of uint64 for block access index#2730
Merged
fselmo merged 1 commit intoethereum:forks/amsterdamfrom Apr 20, 2026
Merged
refactor(spec): use uint32 instead of uint64 for block access index#2730fselmo merged 1 commit intoethereum:forks/amsterdamfrom
fselmo merged 1 commit intoethereum:forks/amsterdamfrom
Conversation
4757a3f to
4f69758
Compare
spencer-tb
approved these changes
Apr 20, 2026
Contributor
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM! Sorry for the u64 change haha
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2730 +/- ##
================================================
Coverage 86.26% 86.26%
================================================
Files 599 599
Lines 37038 37038
Branches 3795 3795
================================================
Hits 31949 31949
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
All good, this was just (re)decided 😄 ... this time on ACDT and was agreed upon. EIP change incoming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
As discussed in ACDT #78, move to using
uint32for block access index. Spec change for this is also coming.compare to: #2713
just statictype(scope):.Cute Animal Picture
🐻❄️