Skip to content

feat(spec-specs, tests): add system address BAL tests#2715

Merged
spencer-tb merged 3 commits intoethereum:forks/amsterdamfrom
flcl42:bal-2
Apr 20, 2026
Merged

feat(spec-specs, tests): add system address BAL tests#2715
spencer-tb merged 3 commits intoethereum:forks/amsterdamfrom
flcl42:bal-2

Conversation

@flcl42
Copy link
Copy Markdown
Contributor

@flcl42 flcl42 commented Apr 18, 2026

🗒️ Description

Adds BAL coverage for SYSTEM_ADDRESS handling:

  • test_bal_account_touch_system_address — parametrized across BALANCE, EXTCODESIZE, EXTCODEHASH, EXTCODECOPY, CALL, STATICCALL. Asserts that a real EVM touch from user code lands SYSTEM_ADDRESS in the BAL as an account-only entry.
  • test_bal_invalid_surplus_system_address_from_system_call — asserts clients reject a BAL that includes SYSTEM_ADDRESS solely because it was the synthetic caller of a pre-execution system operation (EIP-4788 beacon roots call).

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (c3462e0) to head (cb724e7).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2715   +/-   ##
================================================
  Coverage            86.26%   86.26%           
================================================
  Files                  599      599           
  Lines                37038    37038           
  Branches              3795     3795           
================================================
  Hits                 31949    31949           
  Misses                4525     4525           
  Partials               564      564           
Flag Coverage Δ
unittests 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flcl42 flcl42 changed the title Add system address BAL tests feat(spec-specs, tests): add system address BAL tests Apr 18, 2026
@flcl42 flcl42 marked this pull request as ready for review April 18, 2026 15:51
@spencer-tb spencer-tb added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-feat Category: an improvement or new feature A-tests Area: Consensus tests. P-high labels Apr 20, 2026
Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a few changes, would like to get it in the next release today :D
cc @fselmo for extra eyes, will merge now and anything else can be a follow up

@spencer-tb spencer-tb merged commit 668cde5 into ethereum:forks/amsterdam Apr 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) A-tests Area: Consensus tests. C-feat Category: an improvement or new feature P-high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants