refactor(specs): move REFUND_AUTH_PER_EXISTING_ACCOUNT and TX_MAX_GAS_LIMIT to gas modules#2700
Open
knQzx wants to merge 1 commit intoethereum:forks/amsterdamfrom
Open
refactor(specs): move REFUND_AUTH_PER_EXISTING_ACCOUNT and TX_MAX_GAS_LIMIT to gas modules#2700knQzx wants to merge 1 commit intoethereum:forks/amsterdamfrom
REFUND_AUTH_PER_EXISTING_ACCOUNT and TX_MAX_GAS_LIMIT to gas modules#2700knQzx wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
Collaborator
|
Needs a rebase |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2700 +/- ##
===================================================
- Coverage 88.62% 88.62% -0.01%
===================================================
Files 577 577
Lines 35659 35661 +2
Branches 3490 3490
===================================================
+ Hits 31604 31605 +1
- Misses 3492 3493 +1
Partials 563 563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
changed the title
REFUND_AUTH_PER_EXISTING_ACCOUNT and TX_MAX_GAS_LIMIT to gas modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2680
Moves these two gas-related constants to their respective gas modules to be consistent with the refactoring done in #2396