Skip to content

feat(test-forks): Gas-limit-aware Fork, fork-aware Environment#2690

Merged
spencer-tb merged 6 commits intoethereum:forks/amsterdamfrom
marioevz:fork-fixture
Apr 17, 2026
Merged

feat(test-forks): Gas-limit-aware Fork, fork-aware Environment#2690
spencer-tb merged 6 commits intoethereum:forks/amsterdamfrom
marioevz:fork-fixture

Conversation

@marioevz
Copy link
Copy Markdown
Member

@marioevz marioevz commented Apr 16, 2026

🗒️ Description

Implements idea from #2687 (comment) to facilitate EIP-8037 testing.

cc @spencer-tb I have not verified that the fixtures produced before and after this PR are an exact match, but I think they should, could you please verify if this PR looks ok and you want to merge to rebase EIP-8037?

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (64dc4ac) to head (1bc4df9).
⚠️ Report is 6 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2690   +/-   ##
================================================
  Coverage            86.25%   86.26%           
================================================
  Files                  599      599           
  Lines                37032    37038    +6     
  Branches              3795     3795           
================================================
+ Hits                 31943    31949    +6     
  Misses                4525     4525           
  Partials               564      564           
Flag Coverage Δ
unittests 86.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb
Copy link
Copy Markdown
Contributor

Nice catch! Thanks for adding this! :D

My understanding is that we only need the with_env_gas_limit function, then using fork = fork.with_env_gas_limit(int(env.gas_limit)) within state/blockchain.py instead of fork.env_gas_limit = int(env.gas_limit)?

Why do we need the other changes?

Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a small bug in the last commit! Understand the full PR now! LGTM!

@spencer-tb spencer-tb added C-feat Category: an improvement or new feature P-high A-test-forks Area: execution_testing.forks labels Apr 17, 2026
@spencer-tb spencer-tb merged commit c3462e0 into ethereum:forks/amsterdam Apr 17, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-forks Area: execution_testing.forks C-feat Category: an improvement or new feature P-high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants