Skip to content

feat: upgrade contract addresses for Okx Dexrouter V1.0.8-suffix-compat - #2548

Closed
Refrain-123 wants to merge 1 commit into
ethereum:masterfrom
Refrain-123:feat/upgrade-contracts-V1.0.8-suffix-compat
Closed

Refrain-123 wants to merge 1 commit into
ethereum:masterfrom
Refrain-123:feat/upgrade-contracts-V1.0.8-suffix-compat

Conversation

@Refrain-123

Copy link
Copy Markdown
Contributor

Updated contract addresses for the new V1.0.8-suffix-compat deployment across 26 chains.

@github-actions github-actions Bot added the descriptors Changes to clear signing descriptors label May 8, 2026
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

🧪 Clear Signing Tests

⏳ Waiting for maintainer approval to run tests.

This PR is from a fork. A maintainer needs to add the run-tests label to trigger the clear signing tests.

Once approved, the tests will run automatically and post screenshots here.

@github-actions

github-actions Bot commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

Clear Signing Tests

Tested e84b638 · started 2026-08-20 16:04 UTC · finished 2026-08-20 16:04 UTC

❌ 1 affected descriptor(s) have no test file:

  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json

Create a test file at registry/<entity>/testsv2/<descriptor-name>.tests.json. See testing documentation for details.

@manuelwedler
manuelwedler force-pushed the feat/upgrade-contracts-V1.0.8-suffix-compat branch from c583c11 to e84b638 Compare August 20, 2026 16:04
@github-actions

Copy link
Copy Markdown
Contributor

Clear signing recommendations

These are suggestions. They do not block this pull request.

13 format(s) have no interpolatedIntent. A wallet prefers it over intent, because it puts the values of the transaction in the sentence that the signer reads.

  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — dagSwapByOrderId(uint256 orderId, (uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, (address[] mixAdapters, address[] assetTo, uint2
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — dagSwapTo(uint256 orderId, address receiver, (uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, (address[] mixAdapters, address[] ass
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — smartSwapByOrderId(uint256 orderId, (uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, uint256[] batchesAmount, (address[] mixAdapter
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — smartSwapTo(uint256 orderId, address receiver, (uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, uint256[] batchesAmount, (address[]
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — swapWrap(uint256 orderId, uint256 rawdata)
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — swapWrapToWithBaseRequest(uint256 orderId, address receiver, (uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest)
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — uniswapV3SwapTo(uint256 receiver, uint256 amount, uint256 minReturn, uint256[] pools)
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — uniswapV3SwapToWithBaseRequest(uint256 orderId, address receiver, (uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, uint256[] pools)
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — unxswapByOrderId(uint256 srcToken, uint256 amount, uint256 minReturn, bytes32[] pools)
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — unxswapTo(uint256 srcToken, uint256 amount, uint256 minReturn, address receiver, bytes32[] pools)
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — unxswapToWithBaseRequest(uint256 orderId, address receiver, (uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, bytes32[] pools)
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — smartSwapByInvest((uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, uint256[] batchesAmount, (address[] mixAdapters, address[] asset
  • registry/okx/calldata-OkxDexRouterV1.0.8-suffix-compat.json — smartSwapByInvestWithRefund((uint256 fromToken, address toToken, uint256 fromTokenAmount, uint256 minReturnAmount, uint256 deadLine) baseRequest, uint256[] batchesAmount, (address[] mixAdapters, addre

@kuzdogan

Copy link
Copy Markdown
Member

Thanks for the update. CI is failing on the "Require testsv2 files" check, not on the descriptor itself:

No testsv2 file for this descriptor. Create registry/<entity>/testsv2/<descriptor-name>.tests.json

Since the "Common Test Strategy" change (#2586), every changed descriptor must ship a v2 test fixture at registry/<entity>/testsv2/<descriptor-name>.tests.json. calldata-OkxDexRouterV1.0.8-suffix-compat.json has none — the only OKX fixture is for the older calldata-OkxDexRouterV1.0.7-multi-commission descriptor. Files under the legacy tests/ folder are not read by CI, so adding one there would not help.

To unblock this PR, please add registry/okx/testsv2/calldata-OkxDexRouterV1.0.8-suffix-compat.tests.json with at least one real transaction per function the descriptor covers. registry/okx/testsv2/calldata-OkxDexRouterV1.0.7-multi-commission.tests.json is a good template for the shape (descriptor, tests[] with rawTx, txHash, and expected: { intent, owner, fields }), and the "Reference test cases" section of the README describes the format. Once the fixture is in, the Sourcify and Rust runners will execute it automatically.

Marking as blocked until the fixture is added.

Posted with Claude Code

@kuzdogan kuzdogan moved this from Triage to Blocked in Clear Signing PM Aug 26, 2026
@kuzdogan

Copy link
Copy Markdown
Member

Closing due to inactivity

@kuzdogan kuzdogan closed this Sep 21, 2026
@github-project-automation github-project-automation Bot moved this from Blocked to Done in Clear Signing PM Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

descriptors Changes to clear signing descriptors run-tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants