Skip to content

fix: handle JSR registry deps in CI plugin installation #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnMcLear wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle JSR registry deps in CI plugin installation #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/backend-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,22 @@ jobs:
working-directory: ./etherpad-lite
run: bin/installDeps.sh
- name: Install plugin
working-directory: ./etherpad-lite
run: |
pnpm run plugins i --path ../../plugin
# Copy .npmrc to etherpad-lite so pnpm can resolve JSR-scoped packages
cp plugin/.npmrc etherpad-lite/.npmrc 2>/dev/null || true
cd etherpad-lite
# Install plugin; if live-plugin-manager fails on npm: aliases,
# fall back to manual symlink + pnpm install
if ! pnpm run plugins i --path ../../plugin 2>/dev/null; then
echo "live-plugin-manager failed, installing plugin manually..."
PLUGIN_NAME=$(node -p "require('../plugin/package.json').name")
PLUGIN_PKG_DIR="src/plugin_packages/.versions/${PLUGIN_NAME}@$(node -p "require('../plugin/package.json').version")"
mkdir -p "$PLUGIN_PKG_DIR"
rsync -a --exclude node_modules ../plugin/ "$PLUGIN_PKG_DIR/"
cd "$PLUGIN_PKG_DIR" && pnpm install --no-frozen-lockfile && cd -
# Symlink into node_modules so mocha can find the tests
ln -sf "$(pwd)/$PLUGIN_PKG_DIR" "src/node_modules/$PLUGIN_NAME"
fi
-
name: Run the backend tests
working-directory: ./etherpad-lite/src
Expand Down
Loading