docs: normalize gh# issue references to bare #N across codebase#1106
Merged
Conversation
GitHub does not auto-link 'gh#508'; the repository's intended convention is a bare '#508'. The 'gh#' prefix had leaked into reader-facing comments and test docstrings from beads issue-source bookkeeping. This sweep drops the 'gh' prefix from the 27 remaining instances across cnvlib/ and test/, following the two already corrected in PR #1104 (e2722ee). Pure prose; no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 73 73
Lines 7946 7946
Branches 1405 1405
=======================================
Hits 5621 5621
Misses 1881 1881
Partials 444 444
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Newer matplotlib type stubs (as installed in CI's force-reinstalled environment) make Axes.get_figure() return Any, so warn_return_any flags 'return axis.get_figure()' as no-any-return -- an error code not covered by the existing 'type: ignore[return-value]'. Older stubs typed the return as Figure | None, which produced return-value instead. Cover both codes so the suppression is robust across stub generations (warn_unused_ignores is off, so the unused code is harmless locally). Surfaced by CI on PR #1106. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub does not auto-link
gh#508; the repository's original and intended convention is a bare#508. Thegh#prefix had leaked into reader-facing code comments and test docstrings from beads issue-source bookkeeping.This sweep drops the
ghprefix from the 27 remaining instances acrosscnvlib/andtest/, following the two already corrected in PR #1104 (commit e2722ee).Scope
(#881, gh#508)→(#881, #508).grep -rn "gh#" test/ cnvlib/ skgenome/ doc/returns empty afterward.Verification
grepconfirms zero remaininggh#references.test_properties.py,test_vary.py,test_segmentation.py): 99 passed.Closes cnvkit-p3w.
🤖 Generated with Claude Code