Skip to content

Add local and utc popper to logs#1970

Merged
travjenkins merged 8 commits into
mainfrom
travjenkins/feature/time-stamp-popup
May 13, 2026
Merged

Add local and utc popper to logs#1970
travjenkins merged 8 commits into
mainfrom
travjenkins/feature/time-stamp-popup

Conversation

@travjenkins
Copy link
Copy Markdown
Member

@travjenkins travjenkins commented May 8, 2026

Issues

#1969

Changes

1969

  • Start the basis of a reusable more powerful tooltip component. Not perfect but a start.
  • Added a popper for showing times for logs

Tests

Manually tested

  • Tested the logs on the details page. Hovered, clicked, and moved around a lot trying to break stuff

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

image

Comment on lines +33 to +38
<Chip
sx={BaseTypographySx}
label={formattedDateTime}
size="small"
variant="outlined"
/>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to chip to maybe drive people to view timestamp as interactable

{showRelative ? (
<>
<Divider sx={{ gridColumn: '1 / -1', my: 0.5 }} />
<Typography component="dt" />
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't perfect - but makes this line sliiiiightly more semantic

@travjenkins travjenkins marked this pull request as ready for review May 8, 2026 20:11
@travjenkins travjenkins requested a review from a team as a code owner May 8, 2026 20:11
@travjenkins travjenkins changed the title Travjenkins/feature/time stamp popup Add local and utc popper to logs May 8, 2026
@travjenkins travjenkins added the change:planned This is a planned change label May 8, 2026
@travjenkins travjenkins merged commit 9e12e38 into main May 13, 2026
7 checks passed
@travjenkins travjenkins deleted the travjenkins/feature/time-stamp-popup branch May 13, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:planned This is a planned change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants