agent: extract email infrastructure into agent::email module#2909
Draft
GregorShear wants to merge 1 commit into
Draft
agent: extract email infrastructure into agent::email module#2909GregorShear wants to merge 1 commit into
GregorShear wants to merge 1 commit into
Conversation
Move EmailSender trait, Sender enum, and ResendSender out of agent::alerts::notifier into a standalone agent::email module so non-alert emails (e.g. invite emails) can reuse the same sending infrastructure. - New agent::email module with EmailSender trait, Sender, ResendSender, and Arc<Sender> impl - Extract EMAIL_WRAPPER_TEMPLATE constant and register_email_wrapper() from notifications crate so non-alert emails can share Estuary branding - Construct Sender at top level in main.rs wrapped in Arc, ready to be shared across alert notifications and future invite email code - alerts::notifier re-exports EmailSender and Sender to preserve the existing public API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move EmailSender trait, Sender enum, and ResendSender out of agent::alerts::notifier into a standalone agent::email module so non-alert emails (e.g. invite emails) can reuse the same sending infrastructure.
Description:
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)