materialize-elasticsearch: add flag to ignore date format mapping change#4467
Merged
Merged
Conversation
In #3284 there was a change to the date format mapping. This change makes the field incompatible and so requires a backfill to validate and publish existing tasks but is otherwise unrequired. Since mappings cannot be updated, the only options are to backfill or ignore the change. This ignores the change but only when a feature flag is set.
jacobmarble
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3284 there was a change to the date format mapping. This change makes the field incompatible and so requires a backfill to validate and publish existing tasks but is otherwise unrequired.
Since mappings cannot be updated, the only options are to backfill or ignore the difference. This ignores the difference but only when a feature flag is set.
Workflow steps:
Existing tasks can be checked to see if they are affected by setting
onIncompatibleSchemaChange: abortand runningflowctl catalog test. If affected the format difference can be ignored by setting the flagignore_mapping_format_changes.Documentation links affected:
None
Notes for reviewers:
(anything that might help someone review this PR)