materialize-redshift: load bounds and DISTSTYLE ALL for temp load table#4460
Open
mdibaiee wants to merge 2 commits into
Open
materialize-redshift: load bounds and DISTSTYLE ALL for temp load table#4460mdibaiee wants to merge 2 commits into
mdibaiee wants to merge 2 commits into
Conversation
danielnelson
approved these changes
May 13, 2026
Contributor
danielnelson
left a comment
danielnelson
left a comment
There was a problem hiding this comment.
LGTM. Would it be worth applying and testing the merge bounds change separately from changing the diststyle in order to be sure they are both giving improvements?
jacobmarble
approved these changes
May 13, 2026
Comment on lines
+177
to
+178
| // at least on Redshift Serverless). The literal 'foo\bar' parses to | ||
| // "foobar" — the backslash and following char are consumed. So we |
Contributor
There was a problem hiding this comment.
If the backslash and following character were consumed, then wouldn't foo\bar parse to fooar?
mdibaiee
force-pushed
the
mahdi/redshift-load-perf
branch
from
ce7aa8b to
d0c077d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)