materialize-s3-iceberg: sort tables by collection key on create#4377
Draft
jacobmarble wants to merge 1 commit into
Draft
materialize-s3-iceberg: sort tables by collection key on create#4377jacobmarble wants to merge 1 commit into
jacobmarble wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When
materialize-s3-icebergcreates a new Iceberg table, set its write sort order to the collection-key fields (identity transform, ascending, nulls-first). Previously tables were created unsorted.Workflow steps:
New tables created after this lands will carry a sort order in their Iceberg metadata; existing tables are untouched.
Documentation links affected:
None.
Notes for reviewers:
identifier_field_idsimplies.iceberg-ctloverFieldSelection.AllFields()(Keys ++ Values ++ Document), so the key field IDs are simply 1..len(Keys).TestIntegrationagainst the dockerized Polaris REST catalog.