Skip to content

source-{various}: harden conditional reduction annotations for hard deletes #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex-Bair wants to merge 1 commit into
base: main
Choose a base branch
from
Open

source-{various}: harden conditional reduction annotations for hard deletes #4362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source-dynamodb/.snapshots/TestDiscovery-additional_table_without_stream_enabled
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,14 @@ Binding 0:
"allOf": [
{
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
18 changes: 18 additions & 0 deletions source-dynamodb/.snapshots/TestDiscovery-multiple_tables_with_various_types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,14 @@ Binding 0:
"allOf": [
{
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down Expand Up @@ -141,8 +147,14 @@ Binding 1:
"allOf": [
{
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down Expand Up @@ -262,8 +274,14 @@ Binding 2:
"allOf": [
{
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions source-dynamodb/.snapshots/TestDiscovery-single_table_with_a_partition_key
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,14 @@ Binding 0:
"allOf": [
{
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
2 changes: 2 additions & 0 deletions source-dynamodb/discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,11 @@ func (driver) Discover(ctx context.Context, req *pc.Request_Discover) (*pc.Respo
},
Required: []string{"_meta"},
If: &jsonschema.Schema{
Required: []string{"_meta"},
Extras: map[string]interface{}{
"properties": map[string]*jsonschema.Schema{
"_meta": {
Required: []string{"op"},
Extras: map[string]interface{}{
"properties": map[string]*jsonschema.Schema{
"op": {
Expand Down
2 changes: 2 additions & 0 deletions source-kafka/src/discover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,10 @@ fn topic_schema_to_collection_spec(
let doc_schema_json = json!({
"x-infer-schema": true,
"if": {
"required": ["_meta"],
"properties": {
"_meta": {
"required": ["op"],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions ...ka/src/snapshots/source_kafka__discover__tests__avro record with scalar compound key.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions ...e-kafka/src/snapshots/source_kafka__discover__tests__nested avro record with scalars.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions source-kafka/src/snapshots/source_kafka__discover__tests__nested json object.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions source-kafka/src/snapshots/source_kafka__discover__tests__no key.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions source-kafka/src/snapshots/source_kafka__discover__tests__single non-scalar avro key.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions ...e-kafka/src/snapshots/source_kafka__discover__tests__single nullable scalar avro key.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions ...e-kafka/src/snapshots/source_kafka__discover__tests__single nullable scalar json key.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions source-kafka/src/snapshots/source_kafka__discover__tests__single scalar avro key.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
6 changes: 6 additions & 0 deletions source-kafka/src/snapshots/source_kafka__discover__tests__single scalar json key.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ expression: snap
{
"type": "object",
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
50 changes: 40 additions & 10 deletions source-kafka/tests/snapshots/test__discover.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@ expression: snap
"op": {
"const": "d"
}
}
},
"required": [
"op"
]
}
}
},
"required": [
"_meta"
]
},
"properties": {
"_meta": {
Expand Down Expand Up @@ -97,9 +103,15 @@ expression: snap
"op": {
"const": "d"
}
}
},
"required": [
"op"
]
}
}
},
"required": [
"_meta"
]
},
"properties": {
"_meta": {
Expand Down Expand Up @@ -167,9 +179,15 @@ expression: snap
"op": {
"const": "d"
}
}
},
"required": [
"op"
]
}
}
},
"required": [
"_meta"
]
},
"properties": {
"_meta": {
Expand Down Expand Up @@ -254,9 +272,15 @@ expression: snap
"op": {
"const": "d"
}
}
},
"required": [
"op"
]
}
}
},
"required": [
"_meta"
]
},
"properties": {
"_meta": {
Expand Down Expand Up @@ -327,9 +351,15 @@ expression: snap
"op": {
"const": "d"
}
}
},
"required": [
"op"
]
}
}
},
"required": [
"_meta"
]
},
"properties": {
"_meta": {
Expand Down
12 changes: 12 additions & 0 deletions source-mongodb/.snapshots/TestDiscover
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@ Binding 0:
},
"document_schema_json": {
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down Expand Up @@ -95,8 +101,14 @@ Binding 1:
},
"document_schema_json": {
"if": {
"required": [
"_meta"
],
"properties": {
"_meta": {
"required": [
"op"
],
"properties": {
"op": {
"const": "d"
Expand Down
Loading
Loading