Skip to content

Fix out-of-bounds read in VoiceKit::load_buf_() #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teancom wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix out-of-bounds read in VoiceKit::load_buf_() #553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b115d0f
Fix out-of-bounds read in VoiceKit::load_buf_()
teancom Feb 22, 2026
cb232e5
Merge branch 'dev' into fix/load-buf-oob-read
teancom Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions esphome/components/voice_kit/voice_kit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "esphome/core/log.h"

#include <cinttypes>
#include <cstring>

namespace esphome {
namespace voice_kit {
Expand Down Expand Up @@ -252,7 +253,7 @@ VoiceKitUpdaterStatus VoiceKit::dfu_update_send_block_() {
}

uint32_t VoiceKit::load_buf_(uint8_t *buf, const uint8_t max_len, const uint32_t offset) {
if (offset > this->firmware_bin_length_) {
if (offset >= this->firmware_bin_length_) {
ESP_LOGE(TAG, "Invalid offset");
return 0;
}
Expand All @@ -262,9 +263,7 @@ uint32_t VoiceKit::load_buf_(uint8_t *buf, const uint8_t max_len, const uint32_t
buf_len = max_len;
}

for (uint8_t i = 0; i < max_len; i++) {
buf[i] = this->firmware_bin_[offset + i];
}
memcpy(buf, &this->firmware_bin_[offset], buf_len);
return buf_len;
}

Expand Down
Loading