Skip to content

Fix metadata mistakes#5612

Queued
bugadani wants to merge 1 commit into
esp-rs:mainfrom
bugadani:metadata-deny
Queued

Fix metadata mistakes#5612
bugadani wants to merge 1 commit into
esp-rs:mainfrom
bugadani:metadata-deny

Conversation

@bugadani
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 27, 2026 08:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Tightens esp-metadata deserialization to catch TOML/schema mismatches earlier, and fixes a few concrete device-metadata mistakes that would otherwise be rejected once strict parsing is enabled.

Changes:

  • Enforce #[serde(deny_unknown_fields)] on all driver configuration structs generated by driver_configs!.
  • Remove/relocate invalid metadata keys in device TOMLs (esp32s2 GPIO signal max fields; esp32p4 GPIO mistakenly containing a DMA field).
  • Fix esp32c61 SOC metadata to use cpu_csr_prv_mode and regenerate esp-metadata-generated outputs accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
esp-metadata/src/cfg.rs Makes driver config structs reject unknown TOML fields to prevent silent metadata drift/typos.
esp-metadata/devices/esp32s2.toml Removes input_signal_max/output_signal_max from [device.gpio] (these are computed, not specified).
esp-metadata/devices/esp32p4.toml Removes misplaced separate_in_out_interrupts from [device.gpio] (DMA-only field).
esp-metadata/devices/esp32c61.toml Replaces unused/incorrect SOC key with correct cpu_csr_prv_mode value.
esp-metadata-generated/src/_generated_esp32c61.rs Regenerated property macro branches for the new SOC property.
esp-metadata-generated/src/_build_script_utils.rs Regenerated build-script cfg/symbol emission for the new SOC property.

Copy link
Copy Markdown
Member

@playfulFence playfulFence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bugadani bugadani added this pull request to the merge queue May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants