Fix metadata mistakes#5612
Queued
bugadani wants to merge 1 commit into
Queued
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens esp-metadata deserialization to catch TOML/schema mismatches earlier, and fixes a few concrete device-metadata mistakes that would otherwise be rejected once strict parsing is enabled.
Changes:
- Enforce
#[serde(deny_unknown_fields)]on all driver configuration structs generated bydriver_configs!. - Remove/relocate invalid metadata keys in device TOMLs (esp32s2 GPIO signal max fields; esp32p4 GPIO mistakenly containing a DMA field).
- Fix esp32c61 SOC metadata to use
cpu_csr_prv_modeand regenerate esp-metadata-generated outputs accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| esp-metadata/src/cfg.rs | Makes driver config structs reject unknown TOML fields to prevent silent metadata drift/typos. |
| esp-metadata/devices/esp32s2.toml | Removes input_signal_max/output_signal_max from [device.gpio] (these are computed, not specified). |
| esp-metadata/devices/esp32p4.toml | Removes misplaced separate_in_out_interrupts from [device.gpio] (DMA-only field). |
| esp-metadata/devices/esp32c61.toml | Replaces unused/incorrect SOC key with correct cpu_csr_prv_mode value. |
| esp-metadata-generated/src/_generated_esp32c61.rs | Regenerated property macro branches for the new SOC property. |
| esp-metadata-generated/src/_build_script_utils.rs | Regenerated build-script cfg/symbol emission for the new SOC property. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.