Skip to content

CI: Fix global symbol and lint checks#5577

Open
JurajSadel wants to merge 1 commit into
esp-rs:mainfrom
JurajSadel:nightly-ci
Open

CI: Fix global symbol and lint checks#5577
JurajSadel wants to merge 1 commit into
esp-rs:mainfrom
JurajSadel:nightly-ci

Conversation

@JurajSadel
Copy link
Copy Markdown
Contributor

closes #5571

@JurajSadel JurajSadel added skip-changelog No changelog modification needed skip-semver-checks labels May 15, 2026
@MabezDev
Copy link
Copy Markdown
Member

Hmm, the clic module isn't already gated on rt 🤔 ? Are there other parts of the interrupt module we're not gating behind rt properly? Why doesn't this fail on normal CI too 🤔.

@JurajSadel
Copy link
Copy Markdown
Contributor Author

Why doesn't this fail on normal CI too 🤔.

The failing command builds esp-hal with --no-default-features --features esp32p4, so rt is disabled

Comment thread esp-hal/Cargo.toml Outdated
@MabezDev
Copy link
Copy Markdown
Member

Why doesn't this fail on normal CI too 🤔.

The failing command builds esp-hal with --no-default-features --features esp32p4, so rt is disabled

I don't understand what this means? We run the same suite on nightly as we do normally, right? So why doesn't this fail there?

@JurajSadel
Copy link
Copy Markdown
Contributor Author

Why doesn't this fail on normal CI too 🤔.

The failing command builds esp-hal with --no-default-features --features esp32p4, so rt is disabled

I don't understand what this means? We run the same suite on nightly as we do normally, right? So why doesn't this fail there?

We are running the global-symbol-check only on nightly, and it builds hal with --no-default-features :

esp-hal/xtask/src/main.rs

Lines 806 to 815 in 72d44d0

Command::new("cargo")
.args(&[
"+esp",
"build",
"--no-default-features",
"--features",
chip,
"--target",
target,
"-Zbuild-std=core",

@bugadani
Copy link
Copy Markdown
Contributor

global-symbol-check should probably respect the configurations we list in Cargo.toml, then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No changelog modification needed skip-semver-checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly CI Failure

4 participants